[PATCH] D157009: [SLP]Fix PR63854: Add proper sorting of pointers for masked stores.

Fri Aug 4 13:03:36 PDT 2023

reames added a comment.

In D157009#4561625 <https://reviews.llvm.org/D157009#4561625>, @ABataev wrote:

> In D157009#4561621 <https://reviews.llvm.org/D157009#4561621>, @reames wrote:
>
>> I've skimmed this, and it looks reasonable to me, but not really an SLP reviewer.
>>
>> I can confirm that this addresses the reduced case from https://github.com/llvm/llvm-project/issues/63854, but not the original un-reduced example from x264.  I suspect the unreduced example is still hitting https://github.com/llvm/llvm-project/issues/63855.
>
> I don't see how it is related to PR63855. Could you point, please?

For clarity, this patch is not.  The original issue which sparked both of these was x264.  I have not reanalyzed, but given only one of them is being fixed here, my assumption is that the other still stands.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157009/new/

https://reviews.llvm.org/D157009