[PATCH] D157103: AMDGPU: Fix counting source modifiers as literal constants

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D157103#4560958 <https://reviews.llvm.org/D157103#4560958>, @Joe_Nash wrote:

> On the other patch, you wrote "This change broke the handling of source modifiers. we're now treating any source modifier operand as a literal" You mean just the code size calculation is broken, right?
>
> Can you please add test cases for GFX11, and something that emits fmamk/fmaak? Those were the motivating cases for the change.

Turns out those are broken. I think the API makes less sense now. "isInlineConstant" only makes sense for a vsrc operand and not an arbitary one. A counts-as-literal-use-something-in-any-operand would make more sense (inverted)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157103/new/

https://reviews.llvm.org/D157103