[PATCH] D152828: [MachineSink][AArch64] Sink instruction copies when they can replace copy into hard register or folded into addressing mode

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 10:21:02 PDT 2023


chill added a comment.

In D152828#4528166 <https://reviews.llvm.org/D152828#4528166>, @dmgreen wrote:

> High level comment - I like having the ability to do this, is there a reason it is a sink, as opposed to a peephole? I think a lot of the time it may just always be profitable to combine into address operands or add+lsl. Is it due to the register pressure?

Yes, I think we should take register pressure into account, as we can replace use of one register with a use of two registers (e.g. `ldr Xd, [Xa]` -> `ldr Xd, [Xn, Xm]`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152828/new/

https://reviews.llvm.org/D152828



More information about the llvm-commits mailing list