[PATCH] D157030: InstCombine: Fold out scale-if-denormal pattern

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:3449
+      }
+    }
   }
----------------
There is alot of duplicate code between the two if statements.
Maybe fold it into a lambda and pass TrueVal/FalseVal and eq/ne as constraints?
At the very least the actual creation of the new instruction code can be hoisted to some shared codes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157030/new/

https://reviews.llvm.org/D157030