[PATCH] D154768: [CSKY] Optimize conditional branch and value select with BTSTI
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 4 08:19:27 PDT 2023
benshi001 added inline comments.
================
Comment at: llvm/lib/Target/CSKY/CSKYInstrInfo.td:170
uint32_t I = N->getZExtValue();
- return llvm::popcount(I) == 1 && I > 0xffff;
+ return llvm::popcount(I) == 1 && I > 0xfff;
}]>;
----------------
This is a typo in my previous commit. The max immediate can be directly encoded into `ANDI32` is 0xfff, not 0xffff.
This is a typo, need not another patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154768/new/
https://reviews.llvm.org/D154768
More information about the llvm-commits
mailing list