[PATCH] D151850: [RISCV] Model all 3 arithmetic sources of vector FMA at MC layer.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3083
   defm _VV : VPseudoTernaryWithPolicy<m.wvrclass, m.vrclass, m.vrclass, m,
-                                      constraint>;
+                                      constraint, /*Commutable*/0>;
 }
----------------
rogfer01 wrote:
> I'm not sure I get this: were they never commutable in the first place due to their widening behaviour?
I think this might be left over from when I added an extra parameter to the class so I had to list this explicitly. Now that there is no parameter, we don't need this change.

But I think we should make vector instructions commutable so MachineCSE can swap operands to find CSE opportunities.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151850/new/

https://reviews.llvm.org/D151850