[PATCH] D113318: [AMDGPU] Make getInstSizeInBytes more generic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added a subscriber: StephenFan.
Herald added a project: All.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7319-7320
+    bool HasLiteral = false;
+    for (int I = 0, E = MI.getNumExplicitOperands(); I != E; ++I) {
+      if (isLiteralConstant(MI, I)) {
+        HasLiteral = true;
----------------
This change broke the handling of source modifiers. we're now treating any source modifier operand as a literal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113318/new/

https://reviews.llvm.org/D113318