[PATCH] D155028: [ConstantHoisting] add XFAIL test case

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka added inline comments.


================
Comment at: llvm/test/Transforms/ConstantHoisting/X86/bad-cases.ll:130
+; The intent of this test is to verify that 68719476705 does not get
+; transformed into 68719476704 + 1 in basic block %d.
+define i1 @foo (ptr %bar) {
----------------
Why shouldn't this expensive constant be hoisted? The `68719476704` should be hoisted out of the BB and only the `add` should stay in %d. Why is  `68719476704` materialized twice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155028/new/

https://reviews.llvm.org/D155028