[PATCH] D156670: AMDGPU/GlobalISel: Handle stacksave/stackrestore

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 06:22:39 PDT 2023


Pierre-vh accepted this revision.
Pierre-vh added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/stacksave_stackrestore.invalid.ll:5
+
+; RUN: not --crash llc -global-isel=1 -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -filetype=null %t/stacksave-error.ll 2>&1 | FileCheck -check-prefix=ERR-SAVE-GISEL %s
+; RUN: not --crash llc -global-isel=1 -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -filetype=null %t/stackrestore-error.ll 2>&1 | FileCheck -check-prefix=ERR-RESTORE-GISEL %s
----------------
nit: why does this test use `amdpal` but the MIR ones don't?
Also is `filetype=null` needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156670/new/

https://reviews.llvm.org/D156670



More information about the llvm-commits mailing list