[PATCH] D154644: [LV] Split off code to create initial VPlan (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9080
 
-  VPlanTransforms::removeRedundantCanonicalIVs(*Plan);
-  VPlanTransforms::removeRedundantInductionCasts(*Plan);
-
-  VPlanTransforms::optimizeInductions(*Plan, *PSE.getSE());
-  VPlanTransforms::removeDeadRecipes(*Plan);
-
-  VPlanTransforms::createAndOptimizeReplicateRegions(*Plan);
-
-  VPlanTransforms::removeRedundantExpandSCEVRecipes(*Plan);
-  VPlanTransforms::mergeBlocksIntoPredecessors(*Plan);
-
-  assert(VPlanVerifier::verifyPlanIsValid(*Plan) && "VPlan is invalid");
-  return std::move(Plan);
+  return Plan;
 }
----------------
Ayal wrote:
> nit: is replacing `return std::move(Plan)` here with `return Plan` possible independent of all other changes?
Yep, split off in 39cf2104507a


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:792
+  VPlanTransforms::removeRedundantExpandSCEVRecipes(Plan);
+  VPlanTransforms::mergeBlocksIntoPredecessors(Plan);
+}
----------------
Ayal wrote:
> nit: do the local calls above need the `VPlanTransforms::` prefix?
Removed the prefix, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154644/new/

https://reviews.llvm.org/D154644