[PATCH] D155821: [TableGen][GlobalISel] Guarantee stable iteration order for stop-after-parse

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

FYI, I get this warning building a release llvm-tblgen:

  /home/davspi01/work/open_source/llvm-project/llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp:672:6: warning: ‘void {anonymous}::CombineRuleBuilder::verify() const’ defined but not used [-Wunused-function]
    672 | void CombineRuleBuilder::verify() const {
        |      ^~~~~~~~~~~~~~~~~~

Presumably because it's called like this:

  bool CombineRuleBuilder::parseAll() {
    if (!parseDefs(*RuleDef.getValueAsDag("Defs")))
      return false;
    if (!parseMatch(*RuleDef.getValueAsDag("Match")))
      return false;
    if (!parseApply(*RuleDef.getValueAsDag("Apply")))
      return false;
    if (!buildOperandsTable())
      return false;
    if (!findRoots())
      return false;
    LLVM_DEBUG(verify());
    return true;
  }

If you could figure out a way to mark it used in release builds that would be great, as something called `verify` being unused is always worrying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155821/new/

https://reviews.llvm.org/D155821