[PATCH] D156358: [AArch64] Do not unnecessarily spill LR because of @llvm.returnaddress

Fri Aug 4 00:27:12 PDT 2023

kristof.beyls added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-signedreturnaddress.ll:6

 ; Armv8.3-A Pointer Authetication requires a special intsruction to strip the
 ; pointer authentication code from the pointer.
----------------
nit: you might be able to spell-correct intsruction -> instruction here while touching this file anyway?

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-signedreturnaddress.ll:23
+; CHECKV83:          mov     x0, x30
+; CHECKV83-NEXT:     xpaci   x0
+; CHECKV83-NEXT:     ret
----------------
Since this function doesn't sign return addresses, the xpaci is not needed, IIUC?
Probably that is yet another optimization that could be implemented. Maybe it's worthwhile to add a FIXME for this here or in AArch64TargetLowering::LowerRETURNADDR?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156358/new/

https://reviews.llvm.org/D156358