[PATCH] D156954: [lit] Improve test output from lit's internal shell

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 13:36:44 PDT 2023


jdenny added a comment.

In D156954#4558080 <https://reviews.llvm.org/D156954#4558080>, @MaskRay wrote:

> Thank you for the nice summary! I just read the internal implementation the other day and glanced at the change. This change is reasonable and the test coverage looks great.

Thanks for the review.

In case anyone missed it, before this lands, we'll need consensus on D154984 <https://reviews.llvm.org/D154984>, and there was a request to do an RFC for that purpose.  I wanted to have this patch to address concerns about D154984 <https://reviews.llvm.org/D154984> first.

> The new built-in `@echo` probably should be mentioned in the summary/commit message as well.

Good idea.  Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156954/new/

https://reviews.llvm.org/D156954



More information about the llvm-commits mailing list