[PATCH] D156722: [CSSPGO] Support stale profile matching for LTO

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2139-2142
+              StringRef CalleeName =
+                  PrevDIL->getScope()->getSubprogram()->getLinkageName();
+              if (CalleeName.empty())
+                CalleeName = PrevDIL->getScope()->getSubprogram()->getName();
----------------
nit: use `PrevDIL->getSubprogramLinkageName()` instead.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2146
+          }
+          continue;
+        }
----------------
Is the `continue` needed since instructions in the same BB may not from a single callsite. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156722/new/

https://reviews.llvm.org/D156722