[PATCH] D156468: [lld-macho] Fixed crashes when linking with incompatible-arch archives/

Thu Aug 3 13:18:45 PDT 2023

MaskRay added a comment.

In D156468#4558575 <https://reviews.llvm.org/D156468#4558575>, @oontvoo wrote:

> In D156468#4558445 <https://reviews.llvm.org/D156468#4558445>, @MaskRay wrote:
>
>> The summary seems to have an unneeded 4-space indentation.
>>
>>> - Simply ignore input archives with incompatible arch (changes from PRESIDENT810@)
>>
>> What is `PRESIDENT810@`?
>
> Sorry, I meant the idea of peek at the first member in the archive to check its arch  in addLazySymbol is taken from this commit https://github.com/PRESIDENT810/llvm-project/commit/3062d0392a7ac2d3a77a303c6af7272dbdac9db6 by PRESIDENT810

You may want to use https://github.com/PRESIDENT810 . It's unclear that `PRESIDENT810` is a username, at least to me...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156468/new/

https://reviews.llvm.org/D156468