[PATCH] D157026: TEST: Remove <iomanip> from gtest

Elliot Goodrich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 13:06:22 PDT 2023


IncludeGuardian added inline comments.


================
Comment at: third-party/unittest/googletest/include/gtest/gtest.h:1739-1745
 # define ASSERT_NE(val1, val2) GTEST_ASSERT_NE(val1, val2)
 #endif

 #if !GTEST_DONT_DEFINE_ASSERT_LE
 # define ASSERT_LE(val1, val2) GTEST_ASSERT_LE(val1, val2)
 #endif

 #if !GTEST_DONT_DEFINE_ASSERT_LT
 # define ASSERT_LT(val1, val2) GTEST_ASSERT_LT(val1, val2)
----------------
Here this code is no longer correct after this change. But it's possible to move the `setprecision` call into the source file and not need a public include of `<iomanip>`.  Here I have removed it since I don't have access to the source file of GoogleTest in LLVM and this is only a proof that the include is not needed anywhere else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157026/new/

https://reviews.llvm.org/D157026



More information about the llvm-commits mailing list