[PATCH] D156973: [AMDGPU] Add extended-image-insts to RemoveIncompatibleFunctions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 12:42:33 PDT 2023


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURemoveIncompatibleFunctions.cpp:107
+    AMDGPU::FeatureDot8Insts,
+    AMDGPU::FeatureExtendedImageInsts,
 };
----------------
Pierre-vh wrote:
> Note: linter did this because we don't have an even amount of features anymore so it doesn't like the 2 column format. I can revert if needed, but I think it's good to keep files clang-formatted.
> If I revert, I'd add clang-format off/on.
I hate how clang-format wants to minimize lines, every list should be split like this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156973/new/

https://reviews.llvm.org/D156973



More information about the llvm-commits mailing list