[PATCH] D156468: [lld-macho] Fixed crashes when linking with incompatible-arch archives/

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked 3 inline comments as done.
oontvoo added inline comments.


================
Comment at: lld/test/MachO/ignore-incompat-arch.s:70
+_main:
+  .quad _caller
+  ret
----------------
MaskRay wrote:
> it'd be slightly better to use a call instead of a data relocation.
Originally I'd used the normal `call[q]` but llvm-mc choked when compiling for arm64 and I didn't want to have two separate input for x86 vs arm64.
So I'd figured `.quad` is more portable - acceptable for both archs

Can you suggest an alternative?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156468/new/

https://reviews.llvm.org/D156468