[PATCH] D156414: [AMDGPU] Break Large PHIs: Take whole PHI chains into account

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:442
       I.getOpcode() == Instruction::UDiv ||
-      I.getOpcode() == Instruction::SRem ||
-      I.getOpcode() == Instruction::URem)
+      I.getOpcode() == Instruction::SRem || I.getOpcode() == Instruction::URem)
     return false;
----------------
Random formatting change


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:554
   Value *LShrOp =
       Builder.CreateLShr(ExtRes, 32 - getBaseElementBitWidth(I.getType()));
+  Value *TruncRes = Builder.CreateTrunc(LShrOp, I.getType());
----------------
Random formatting changes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156414/new/

https://reviews.llvm.org/D156414