[PATCH] D156958: [BOLT][DWARF] Fix handling CU with DW_AT_ranges

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 07:06:30 PDT 2023


ayermolo added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1249
+      std::optional<uint64_t> DWOId = Unit.getDWOId();
+      assert(DWOId && "DWOId is not found for DWO Unit.");
       CurRangeBase = getDwoRangesBase(*DWOId);
----------------
maksfb wrote:
> Are you checking DWOId somewhere else? If not, convert to error. 
not in all code paths that can lead to this function execution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156958/new/

https://reviews.llvm.org/D156958



More information about the llvm-commits mailing list