[PATCH] D156999: [Inline Spiller] Consider bundles when marking defs as dead

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:757
+            LLVM_DEBUG(dbgs() << "All defs dead: " << *It);
+            DeadDefs.push_back(&*It);
+          }
----------------
I don't think you can necessarily just delete any dead defs within the bundle without knowing you can delete all the dead defs in the bundle (with the possible exception of copies)


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:760
+        }
+        It = std::next(It);
+      } while (It != EndIt && It->isBundledWithPred());
----------------
this is just ++It


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156999/new/

https://reviews.llvm.org/D156999