[PATCH] D156873: [Workflow] Run the repository sync script from GH.
Konrad Wilhelm Kleine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 3 05:32:58 PDT 2023
kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: .github/workflows/sync-release-repo.yml:5
+on:
+ workflow_dispatch
+env:
----------------
This is good practice! I'm glad you've pointed it out.
================
Comment at: llvm/utils/git/sync-release-repo.sh:28
git remote add $MAIN_REMOTE "https://github.com/llvm/llvm-project"
-git remote add $RELEASE_REMOTE "https://github.com/llvm/llvm-project-release-prs"
+git remote add $RELEASE_REMOTE "https://token:$GH_TOKEN@github.com/llvm/llvm-project-release-prs"
----------------
Just to be sure: The fact that you've written `GH_TOKEN: ${{ secrets.GH_TOKEN }}` in the workflow file will hide or mask the token here, when looking at the output, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156873/new/
https://reviews.llvm.org/D156873
More information about the llvm-commits
mailing list