[PATCH] D156966: [TableGen] Improve error report of unspecified arguments

[Wang Pengcheng via Phabricator via llvm-commits]

wangpc marked an inline comment as done.
wangpc added a comment.

Thanks!
This patch needs to backport to LLVM Release 17 since it is a fix of bug introduced by named arguments patch.



================
Comment at: llvm/test/TableGen/template-args.td:166
+defm error9: MC1;
+// ERROR9: value not specified for template argument 'MC1::nm'
+// ERROR9: 99:23: note: declared in 'MC1'
----------------
DavidSpickett wrote:
> Just for my understanding, was it decided that `::` would mean things in a multiclass? As opposed to single `:` in a normal class.
Yes! It is the way how TableGen normalizes argument names currently.
(But I think there is no need to distinguish them, I may post a patch to remove the difference later.) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156966/new/

https://reviews.llvm.org/D156966