[PATCH] D156943: [RISCV] Implement straight-forward bf16<->int conversion cases

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 01:00:57 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2443
+    // the result.
+    if ((Src.getSimpleValueType() == MVT::f16 &&
+         !Subtarget.hasStdExtZfhOrZhinx()) ||
----------------
I don't think we need to use getSimpleValueType() here, we can use getValueType() and make the line shorter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156943/new/

https://reviews.llvm.org/D156943



More information about the llvm-commits mailing list