[PATCH] D156505: [AArch64][ELF] Support R_AARCH64_AUTH_ABS64 static relocation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 20:38:23 PDT 2023


MaskRay added inline comments.


================
Comment at: docs/PointerAuth.md:331
+
+At the binary object file level,
+[Authenticated Relocations](#authenticated-global-relocation) are represented
----------------
At the object file level, ...

"binary object file" is not a term.


================
Comment at: docs/PointerAuth.md:333
+[Authenticated Relocations](#authenticated-global-relocation) are represented
+using the ``ARM64_RELOC_AUTHENTICATED_POINTER`` relocation kind (with value
+``0xE100``).
----------------
`ARM64_RELOC_AUTHENTICATED_POINTER` is from Mach-O, but the sentence is written in the context of ELF. You need extra words to mean that this resembles `ARM64_RELOC_AUTHENTICATED_POINTER` from Mach-O.


================
Comment at: docs/PointerAuth.md:344
+```
+
----------------
delete trailing blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156505/new/

https://reviews.llvm.org/D156505



More information about the llvm-commits mailing list