[PATCH] D109661: [FunctionPropertiesAnalysis] Add `PreciseFunctionPropertiesAnalysis`

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 18:10:08 PDT 2023

aidengrossman added a comment.

@uenoku I'm interested in getting this patch into upstream LLVM and addressing the other reviewer comments. Do you mind if I commandeer this revision and tag you as a co-author on the eventual commit?

I talked with @mtrofin briefly (only covering flags/separate pass), and the plan is as follows

- address remaining inline comments
- Refactor `DetailedFunctionPropertiesAnalysis` into `FunctionPropertiesAnalysis` and keep the additional options behind a command line flag. I would like to use actual pass options here similar to how passes like instcombine can take in arguments, but the new pass manager doesn't seem to currently have support for analysis passes with parameters like is present for traditional function passes. I'm not sure how difficult it would be to get this implemented, but it doesn't look trivial.
- Address additional comments, land the patch.



More information about the llvm-commits mailing list