[PATCH] D156957: [BOLT][DWARF] Delete DW_AT_low_pc when converting to ranges.

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 17:59:07 PDT 2023


ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Now that we have new DWARF Rewriter we can remove DW_AT_low_pc when converting
DW_AT_low_pc/DW_AT_high_pc to DW_AT_ranges. Which closer follows DWARF spec.
Leaving CU DW_AT_low_pc in place. Reading the spec I think it's needed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156957

Files:
  bolt/lib/Rewrite/DWARFRewriter.cpp
  bolt/test/X86/debug-fission-single-convert.s
  bolt/test/X86/dwarf4-df-dualcu.test
  bolt/test/X86/dwarf5-df-dualcu.test
  bolt/test/X86/dwarf5-df-mono-dualcu.test
  bolt/test/X86/dwarf5-dwarf4-monolithic.test
  bolt/test/X86/dwarf5-locaddrx.test
  bolt/test/X86/dwarf5-split-dwarf4-monolithic.test
  bolt/test/X86/dwarf5-two-rnglists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156957.546661.patch
Type: text/x-patch
Size: 23374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230803/968d6d47/attachment.bin>


More information about the llvm-commits mailing list