[PATCH] D148043: [InferAttrs] Mark frexp and modf as memory(argmem: write)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 16:44:43 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:481-482
     Changed |= setWillReturn(F);
+    Changed |= setOnlyAccessesArgMemory(F);
+    Changed |= setOnlyWritesMemory(F);
     Changed |= setDoesNotCapture(F, 1);
----------------
vitalybuka wrote:
> this is not true with sanitizers, interceptors may check metadata
> 
> Maybe we can add TargetLibraryInfo::hasSanitizer() and use it here 
If this is actually an issue, it would impact every libcall we mark with memory attributes; please move the discussion elsewhere (maybe a Discourse thread).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148043/new/

https://reviews.llvm.org/D148043



More information about the llvm-commits mailing list