[PATCH] D156850: [NFC][Coroutines] Use a reverse post-order to guide the computation about cross suspend infomation to reach a fixed point faster.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 16:18:32 PDT 2023


MatzeB added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:235-236
 
     // We don't need to count the predecessors when initialization.
     if constexpr (!Initialize)
       // If all the predecessors of the current Block don't change,
----------------
Well we should definitely check the predecessors even in Initialization now, in an RPO order we should have nearly all of them computed already (everything except for backedges).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156850/new/

https://reviews.llvm.org/D156850



More information about the llvm-commits mailing list