[PATCH] D156926: [RISCV] Add bf16 to isFPImmLegal.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 15:14:25 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:848
         llvm_unreachable("Unexpected size");
       case MVT::f16:
         Opc = RISCV::FLI_H;
----------------
reames wrote:
> Don't you need handling for bf16 here?
I think getLegalZfaFPImm should return -1 for bf16 since we don't have a bf16 FLI instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156926/new/

https://reviews.llvm.org/D156926



More information about the llvm-commits mailing list