[PATCH] D156313: [Flang][OpenMP] Improve support for `if` clause on combined constructs

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 14:30:16 PDT 2023


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

Please add debug-dump-unparse or a debug-dump-parse-tree tests for the modifications in the parse-tree or the parser before you submit.



================
Comment at: flang/lib/Lower/OpenMP.cpp:2457
+  default:
+    TODO(currentLocation, "Unhandled block directive");
+    break;
----------------
Nit: While you are here, could you check whether it is possible to print the name of the directive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156313/new/

https://reviews.llvm.org/D156313



More information about the llvm-commits mailing list