[PATCH] D156428: [AArch64][PtrAuth] Fix unwind state for tail calls

Wed Aug 2 14:08:38 PDT 2023

ikudrin added a comment.

Could you update the review to reflect changes in `sign-return-address.ll` after D156327 <https://reviews.llvm.org/D156327>?

In D156428#4554317 <https://reviews.llvm.org/D156428#4554317>, @olista01 wrote:

> This also revealed another future optimisation opportunity: move the
> negate_ra_state forward to the same location as the other unwind opcodes, to
> save one advance_loc per function.

Right, thanks. Do you want to prepare a patch for this?

================
Comment at: llvm/test/CodeGen/AArch64/sign-return-address-cfi-negate-ra-state.ll:210-217
+; CHECK-DUMP-LABEL: FDE
+; CHECK-DUMP-NEXT: Format:       DWARF32
+; CHECK-DUMP-NEXT:   DW_CFA_advance_loc: 4
+; CHECK-DUMP-NEXT:   DW_CFA_AARCH64_negate_ra_state:
+; CHECK-DUMP-NEXT:   DW_CFA_advance_loc: 4
+; CHECK-DUMP-NEXT:   DW_CFA_def_cfa_offset: +16
+; CHECK-DUMP-NEXT:   DW_CFA_offset: W30 -16
----------------
Perhaps remove excess details to make the test more robust?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156428/new/

https://reviews.llvm.org/D156428