[PATCH] D149095: [llvm-objdump] Support CHPE code ranges in disassembler.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 2 12:55:25 PDT 2023
MaskRay accepted this revision.
MaskRay added a comment.
Nit about a test
================
Comment at: llvm/test/tools/llvm-objdump/COFF/arm64ec-unsupported.yaml:1
+# REQUIRES: aarch64-registered-target, !x86-registered-target
+
----------------
This is uncommon and will make many build configurations not able to detect this issue.
Keep just `# REQUIRES: aarch64-registered-target` and use
```
RUN: %if !x86-registered-target %{ ... %}
```
so that most RUN lines in this test are still testable on a default configuration that builds all non-experimental targets.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149095/new/
https://reviews.llvm.org/D149095
More information about the llvm-commits
mailing list