[PATCH] D156852: [AMDGPU] Use inreg for hint to preload kernel arguments

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:924
+  for (unsigned I = 0;
+       I < F.arg_size() && I < std::min(KernargPreloadCount.getValue(), 16u);
+       ++I) {
----------------
arsenm wrote:
> Assuming 1 register : 1 argument which is not the case.
> 
> Also the user SGPR count went up (in gfx10 I think?) so you should query the number for that
AFAIR it was increased to 32 in gfx9, then again was 16 in gfx10. I also do not think this is implemented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156852/new/

https://reviews.llvm.org/D156852