[PATCH] D155845: [VPlan] Fix in-loop reduction chains using VPlan def-use chains (NFCI)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9242
+                   PreviousLinkV &&
+               "PreviousLinkV must be the other operand than VecOp");
       }
----------------
Ayal wrote:
> 
Sounds better, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9244
+      VPRecipeBase *CompareRecipe =
+          CurrentLink->getOperand(0)->getDefiningRecipe();
+
----------------
Ayal wrote:
> fhahn wrote:
> > Ayal wrote:
> > > fhahn wrote:
> > > > Ayal wrote:
> > > > > Could we use PreviousLink serve as/instead of CompareRecipe?
> > > > Unfortunately I don't think so, but we can let dead-recipe removal take care of this removal. I removed the code.
> > > If PreviousLink is set to Cmp before early-continuing above?
> > > 
> > > OTOH, dead-recipe removal could also reclaim CurrentLink.
> > Yep, updated, thanks!
> nit: may be worth noting somewhere that this transformation may leave dead recipes for a subsequent pass to clean up.
Added a note in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155845/new/

https://reviews.llvm.org/D155845