[PATCH] D156445: [BPF] Avoid repeating MI->getOperand(NumDefs) x3
Eduard Zingerman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 2 07:58:34 PDT 2023
eddyz87 added a comment.
In my opinion, whether or not to repeat `MI->getOperand(NumDefs)` is a matter of personal preference in this case. Current code is ok and this change does not change any related functionality. I suggest to withheld from this change to avoid cluttering commit history.
Also, I don't understand why you landed this change w/o due process.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156445/new/
https://reviews.llvm.org/D156445
More information about the llvm-commits
mailing list