[PATCH] D152998: [TableGen] Support named arguments

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 07:33:39 PDT 2023


DavidSpickett added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:598
+                            UnsolvedArgName->getAsUnquotedString() +
+                            ") of multiclass '" + Rec->getNameInitAsString() +
+                            "'");
----------------
I noticed this working on my Tablegen notebooks, the following example gives the error, but is not itself a multiclass at least not from the user's point of view:
```
class C <int a, int b> {
    int c = a;
    int d = b;
}
def X: C<0> {}
```
```
$ ./bin/llvm-tblgen /tmp/test.td
/tmp/test.td:5:8: error: value not specified for template argument (C:b) of multiclass 'C'
def X: C<0> {}
       ^
```
Do you have enough information in this context to be able to make the error message more accurate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152998/new/

https://reviews.llvm.org/D152998



More information about the llvm-commits mailing list