[PATCH] D155786: [LV] Rename the Select[I|F]Cmp reduction pattern to [I|F]AnyOf. (NFC)

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

This looks good to me, thanks for the cleanup!
Adding a couple of minor nits.



================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:368-371
+/// values: 1) an initial PHI start value, and 2) a loop invariant value. This
+/// function uses \p LoopExitInst to determine 2), which we then use to select
+/// between \p Left and \p Right. Any lane value in \p Left that matches 2) will
+/// be merged into \p Right.
----------------
Fixing this original documentation, while we're updating it: there is no \p LoopExitInst here.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4029-4032
       if (Op != Instruction::ICmp && Op != Instruction::FCmp) {
         ReducedPartRdx = Builder.CreateBinOp(
             (Instruction::BinaryOps)Op, RdxPart, ReducedPartRdx, "bin.rdx");
+      } else if (RecurrenceDescriptor::isAnyOfRecurrenceKind(RK))
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155786/new/

https://reviews.llvm.org/D155786