[PATCH] D156880: [AggressiveAntiDepBreaker] Refix renaming a subregister of a live register

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 05:28:16 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/AggressiveAntiDepBreaker.h:179
     BitVector GetRenameRegisters(unsigned Reg);
-    bool FindSuitableFreeRegisters(unsigned AntiDepGroupIndex,
-                                   RenameOrderType& RenameOrder,
+    bool FindSuitableFreeRegisters(unsigned SuperReg,
+                                   unsigned AntiDepGroupIndex,
----------------
arsenm wrote:
> use Register instead of unsigned
Good idea, but I'd prefer to do that as a separate cleanup for all the code in this pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156880/new/

https://reviews.llvm.org/D156880



More information about the llvm-commits mailing list