[PATCH] D153638: [CodeGenPrepare][NFC] Update the dominator tree instead of rebuilding it

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 02:53:03 PDT 2023


chill added a comment.

In D153638#4553265 <https://reviews.llvm.org/D153638#4553265>, @chill wrote:

> I couldn't so far reproduce it (basic config with assertions and expensive checks).
> Maybe `llvm::make_early_inc_range(F)`  fails because of non-finalised deletion of blocks ... I'll keep on digging.

Quite likely.

I did a bootstrap on a slightly modified version where I forced the integrity checks on the DT tree,
unfortunately that had the side-effect of forcing DTU updates.

When I remove the checks I get the crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153638/new/

https://reviews.llvm.org/D153638



More information about the llvm-commits mailing list