[PATCH] D156522: [LLVM] move verification of convergence control to a class template

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 02:07:17 PDT 2023


sameerds updated this revision to Diff 546363.
sameerds added a comment.

- rebase
- fix build failures:
  - Shared libraries build failed with undefined references due to "extern template" declarations.
  - Modules build failed due to a cycle dependence between llvm/ADT and llvm/IR. The Generic*Impl.h files should be in llvm/IR to prevent this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156522/new/

https://reviews.llvm.org/D156522

Files:
  llvm/include/llvm/ADT/GenericConvergenceVerifier.h
  llvm/include/llvm/ADT/GenericSSAContext.h
  llvm/include/llvm/IR/ConvergenceVerifier.h
  llvm/include/llvm/IR/GenericConvergenceVerifierImpl.h
  llvm/lib/CodeGen/MachineSSAContext.cpp
  llvm/lib/IR/CMakeLists.txt
  llvm/lib/IR/ConvergenceVerifier.cpp
  llvm/lib/IR/SSAContext.cpp
  llvm/lib/IR/Verifier.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156522.546363.patch
Type: text/x-patch
Size: 26010 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230802/e9eeef57/attachment.bin>


More information about the llvm-commits mailing list