[PATCH] D156758: [dwp][libtool-darwin][sancov] Enable llvm-driver

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

I think a better solution would be change the type of linkage from `PRIVATE` to `PUBLIC`. To give a concrete example, in https://github.com/llvm/llvm-project/blob/244fd4dfc56a0d59655c65adac6a7258114b8af2/llvm/tools/dsymutil/CMakeLists.txt#L42 you'd use:

  target_link_libraries(dsymutil PUBLIC "-framework CoreFoundation")

When driver is not being used, `add_llvm_tool` bottoms out in `add_executable` and there's no difference to `PRIVATE` and `PUBLIC`, but when driver is enabled `add_llvm_tool` bottoms out in `add_library(... OBJECT ...)` and there `PUBLIC` is correct because it'll make sure that the link flags will be transitively propagated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156758/new/

https://reviews.llvm.org/D156758