[PATCH] D156845: [ConstantRange] Calculate precise range for shl by -1

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 22:28:46 PDT 2023


goldstein.w.n added a comment.

The proofs shouldn't only be for `32`. It should use param C that you setup with assumes



================
Comment at: llvm/test/Transforms/FunctionSpecialization/and-add-shl.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
-; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+; RUN: opt < %s -passes=ipsccp -S | FileCheck %s
 
----------------
Should the tests be in a different place? At the very least please precommit change of pass so we can more accurately see what's the result of the code change vs the pass change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156845/new/

https://reviews.llvm.org/D156845



More information about the llvm-commits mailing list