[PATCH] D156215: [DAGCombiner] Reassociate the operands from (OR (OR(CMP1, CMP2)), CMP3) to (OR (OR(CMP1, CMP3)), CMP2)

Konstantina Mitropoulou via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 21:45:04 PDT 2023


kmitropoulou added a comment.

In D156215#4538242 <https://reviews.llvm.org/D156215#4538242>, @foad wrote:

> Seems reasonable, but I wonder how often this helps in real code.

I ran the Vulcan game tests (https://github.amd.com/Vulkan/Tests/tree/master/shadertest/game). The reassociateOpsCommutative() is called 115168 times and the proposed optimization is triggered 302 times. So, I will abandon the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156215/new/

https://reviews.llvm.org/D156215



More information about the llvm-commits mailing list