[PATCH] D151414: [RISCV] Add Zvfhmin extension support for llvm RISCV backend.

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 19:58:31 PDT 2023


jacquesguan added a comment.

In D151414#4552130 <https://reviews.llvm.org/D151414#4552130>, @michaelmaitland wrote:

> If I add RUN line with `zvfhmin` instead of `zvfh` `llvm/test/CodeGen/RISCV/rvv/vfwnmacc-vp.ll`, the compiler gives `LLVM ERROR: Cannot select: t31: nxv1f32 = RISCVISD::VFWNMADD_VL t2, t4, t6, t8, t13`, followed by trace.  Probably need to check for zvfh in `performVFMADD_VLCombine`? Also maybe need to check in other functions like `performFADDSUB_VLCombine`?

Thanks to point it. I add a check to prevent the combination to widen op when we have only zvfhmin. But these test can not pass with RUN line zvfhmin because the vf form need promotion of splat, when implement in https://reviews.llvm.org/D153848.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151414/new/

https://reviews.llvm.org/D151414



More information about the llvm-commits mailing list