[PATCH] D156835: CoroFrame: Rework SuspendCrossingInfo analysis

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

Looks pretty good. Thanks.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:217
 
-template <bool Initialize> bool SuspendCrossingInfo::computeBlockData() {
-  const size_t N = Mapping.size();
-  bool Changed = false;
-
-  for (size_t I = 0; I < N; ++I) {
-    auto &B = Block[I];
+void SuspendCrossingInfo::visitBlock(const BasicBlock &BB, BlockData &B) {
+  // Propagate Kills and Consumes from predecessors into B. This is a dataflow
----------------
Is it better to have only one `BasicBlock` arguments? Then we can get the BlockData and the Block index by `Mapping` and `Block`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156835/new/

https://reviews.llvm.org/D156835