[PATCH] D156018: [BOLT] Impl createRelocation for AArch64

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 19:51:59 PDT 2023


Amir added a comment.

Can you please retitle it as "[BOLT] Implement createRelocation for AArch64"?



================
Comment at: bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp:1207-1213
+    // Extract a symbol and an addend out of the fixup value expression.
+    //
+    // Only the following limited expression types are supported:
+    //   Symbol + Addend
+    //   Symbol + Constant + Addend
+    //   Const + Addend
+    //   Symbol
----------------
This part looks to be common for X86 and AArch64. Can you please factor it out (in a separate diff)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156018/new/

https://reviews.llvm.org/D156018



More information about the llvm-commits mailing list