[PATCH] D145662: [Xtensa] Implement asm representation of the Constant Pool.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.
Herald added a subscriber: sstefan1.

Tests?



================
Comment at: llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp:106
+        str += LblSym->getName();
+        str += ", ";
+        const Constant *C = CPE.Val.ConstVal;
----------------
use a raw_string_ostream with a SmallString?


================
Comment at: llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp:197-198
+    if (ACPV->getModifier() != XtensaCP::no_modifier) {
+      std::string SymName(MCSym->getName());
+      MCSym = GetExternalSymbolSymbol(StringRef(SymName));
+    }
----------------
Don't need string copy?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145662/new/

https://reviews.llvm.org/D145662