[PATCH] D153257: AMDGPU: Implement llvm.set.rounding

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.set.rounding.ll:16-18
+; GFX678-NEXT:    s_add_i32 s34, s4, -4
+; GFX678-NEXT:    s_cmp_lt_u32 s4, 4
+; GFX678-NEXT:    s_cselect_b32 s34, s4, s34
----------------
foad wrote:
> Simpler:
> ```
>   s_add_i32 s34, s4, -4
>   s_min_u32 s34, s4, s34
> ```
I would have hoped the combiner would deal with that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153257/new/

https://reviews.llvm.org/D153257