[PATCH] D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push.
Kito Cheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 17:14:36 PDT 2023
kito-cheng added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:584
// simply calculated from the frame index.
if (FrameIdx < 0)
+ if (RVFI->isPushable(MF)) {
----------------
Nit:
I think this need more curly brackets around there:
```
if (FrameIdx < 0) {
if (RVFI->isPushable(MF)) {
...
} else {
...
}
} else {
...
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156437/new/
https://reviews.llvm.org/D156437
More information about the llvm-commits
mailing list